Skip to content

Fix live streaming when generating planning steps #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

FlorianVal
Copy link
Contributor

Issue #1347. A CodeAgent can't stream and plan at the same time. even if the code line :

if self.stream_outputs and hasattr(self.model, "generate_stream"):

Was implemented, the behavior to stream was not right.

I took the same behavior as presented in _step_stream and adapted it to the function to stream plan messages.

Now the streaming is working with planning.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@albertvillanova albertvillanova merged commit ddfedf5 into huggingface:main May 19, 2025
3 checks passed
@FlorianVal FlorianVal deleted the fix/cant_stream_and_plan branch May 20, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't stream and plan with Ollama for a CodeAgent.
2 participants