Replace AgentGenerationError with AgentParsingError for ToolCallingAgent #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AgentGenerationErrors
are designed to be caught, because they mean that inference was improperly setup: however forToolCallingAgent
where sometimes the model can just output bad formatted tool calls on the api side that do not get extracted as a proper tool call, we can be more indulgent and let the model retry by making the error anAgentParsingError
instead, which is not raised but returned to the agent. This is mostly a hotfix, to be refined later. Also, reminder:ToolCallingAgent
is not the primary class that we support, the preferred class isCodeAgent
.