Skip to content

Replace AgentGenerationError with AgentParsingError for ToolCallingAgent #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

aymeric-roucher
Copy link
Collaborator

AgentGenerationErrors are designed to be caught, because they mean that inference was improperly setup: however for ToolCallingAgent where sometimes the model can just output bad formatted tool calls on the api side that do not get extracted as a proper tool call, we can be more indulgent and let the model retry by making the error an AgentParsingError instead, which is not raised but returned to the agent. This is mostly a hotfix, to be refined later. Also, reminder: ToolCallingAgent is not the primary class that we support, the preferred class is CodeAgent.

@aymeric-roucher aymeric-roucher merged commit 41f827a into main Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant