Modify the examples optimization level #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
regisss
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
It looks good to me @echarlaix !!
I just have one question because I'm curious
| @@ -53,7 +53,7 @@ def test_optimize(self): | |||
| "roberta-base", | |||
| "google/electra-small-discriminator", | |||
| } | |||
| optimization_config = OptimizationConfig(optimization_level=99, optimize_with_onnxruntime_only=False) | |||
| optimization_config = OptimizationConfig(optimization_level=2, optimize_with_onnxruntime_only=False) | |||
There was a problem hiding this comment.
Why 2 and not 1 here for optimization_level?
There was a problem hiding this comment.
For the tests, I think it's better to verify that even the extended graph optimizations don't impact too much the models outputs. The optimization level of 99 doesn't seem useful in our use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we modify the onnx runtime optimization level in the examples in the quickstart and different READMEs for users to create hardware agnostic optimized graph.