Skip to content

Add qwen3 family #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add qwen3 family #1948

wants to merge 12 commits into from

Conversation

tianyuan211
Copy link

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@regisss
Copy link
Collaborator

regisss commented Apr 24, 2025

On which version of Transformers is this PR based?

@tianyuan211
Copy link
Author

On which version of Transformers is this PR based?

this is for Transformers 4.51, which includes the qwen3 model; I just add the qwen3 code part, not changing the other code which may influence the generation process.

@regisss
Copy link
Collaborator

regisss commented Apr 30, 2025

@tianyuan211 Can you also add the following please?

  • a text-generation test here: https://github.com/huggingface/optimum-habana/blob/main/tests/test_text_generation_example.py
  • update this line in the README "Qwen2" --> "Qwen2 / Qwen3":
    | Qwen2 | <li>Single card</li> | <li>Single card</li> | <li>[language modeling](https://github.com/huggingface/optimum-habana/tree/main/examples/language-modeling)</li><li>[text generation](https://github.com/huggingface/optimum-habana/tree/main/examples/text-generation)</li> |
  • same in the table of the doc:
    | Qwen2 | <div style="text-align:left"><li>Single card</li></div> | <div style="text-align:left"><li>Single card</li></div> | <li>[language modeling](https://github.com/huggingface/optimum-habana/tree/main/examples/language-modeling)</li><li>[text generation](https://github.com/huggingface/optimum-habana/tree/main/examples/text-generation)</li> |

@tianyuan211 tianyuan211 reopened this May 8, 2025
@tianyuan211 tianyuan211 changed the title Add qwen3 Add qwen3 family May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants