Skip to content

Upgrade AllenNLP + hotfix #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 23, 2021
Merged

Upgrade AllenNLP + hotfix #287

merged 11 commits into from
Aug 23, 2021

Conversation

osanseviero
Copy link
Contributor

@osanseviero osanseviero commented Aug 19, 2021 •
edited
Loading

This PR includes multiple fixes and changes

  • Upgrades allennlp image to use api-inference-community
  • Fix API Inference for allennlp (it was missing hf// prefix)
  • Improve code snippet for unknown type since we can still show how to load a model
  • Fix docker test GA workflow
  • Ensure style/quality are done for docker_images + some style fixes

FYI @LysandreJik

@osanseviero osanseviero changed the title Fix AllenNLP inference and improve code snippet Upgrade AllenNLP + hotfix Aug 19, 2021
@osanseviero osanseviero requested a review from Narsil August 19, 2021 15:39
Narsil
Narsil approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, we'll have to figure out why docker tests fails.

This was referenced Aug 19, 2021
Merged
Merged
@Narsil Narsil merged commit 1ec86b3 into main Aug 23, 2021
@Narsil Narsil deleted the fix_allennlp branch August 23, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narsil Narsil Narsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osanseviero @Narsil