[MCP] include assistant tool call before tool response + bug fix #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1614.
Also, while experimenting with tiny-agents using OpenAI's gpt-4o, I noticed that the assistant's tool call wasn t being appended to the message list before the tool call result. This didn't cause issues before, likely because the models inferred the missing function call context from the tool response. However, it seems that OpenAI is stricter about message ordering and expect the assistant's tool call to be explicitly in the conversation history.
Note: the fix is already implemented in Python tiny-agents : huggingface/huggingface_hub#3159