Skip to content

Basic Xorb creation + Add xet-core WASM bindings #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

coyotte508
Copy link
Member

@coyotte508 coyotte508 commented Jul 11, 2025

This doesn't handle dedup at all yet, will not be used as is even if I merge it.

What it does:

  • Write chunks into xorb
  • Write chunk headers
  • Handle compression
  • Handle xorb size limit and xorb chunk count limit

Questions:

  • Are there xorb headers? I'm writing chunk headers before each chunk, but is there a xorb header at the beginning of the xorb to write? No, thanks @assafvayner
  • For now I only test lz4 compression length against uncompressed length, I do not bother with bg4. Should I test both?
  • Is the xet backend hardened against invalid chunks/xorbs?

cc @assafvayner @seanses @hoytak @sirahd @rajatarya for viz and if you have answers to the questions :)

Copy link
Member Author

@coyotte508 coyotte508 Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we'll be able to bring that wasm size down (eg maybe trimming down the merkle tree / hash logic for the xorb hash to the mininum would help)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrote the file generated by wasmbindgen to TS + make it work in node & web + add init() function

@coyotte508 coyotte508 changed the title Basic Xorb creation Basic Xorb creation + Add xet-core WASM bindings Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant