Skip to content

Featherless provider: max_tokens #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Featherless provider: max_tokens #1474

wants to merge 4 commits into from

Conversation

pohnean
Copy link

@pohnean pohnean commented May 21, 2025

This PR fixes the parameters that are passed into the featherless api, in particular the max_token.

hanouticelina
hanouticelina approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for the fix

@SBrandeis
Copy link
Contributor

Thanks for the fix @pohnean !
Don't forget to run pnpm format and pnpm run lint in the packages/inference folder to conform our code style checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SBrandeis SBrandeis SBrandeis left review comments

@hanouticelina hanouticelina hanouticelina approved these changes

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pohnean @SBrandeis @hanouticelina