Skip to content

[Inference Providers] feat. Refactor the NovitaTextToVideoTask using the async API. #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Inference Providers] feat. Refactor the NovitaTextToVideoTask using the async API. #1459

wants to merge 8 commits into from

Conversation

viktor2077
Copy link
Contributor

This PR refactors the NovitaTextToVideoTask using the async API, aiming to allow inference with models that may take over 2 minutes to generate results.

SBrandeis
SBrandeis reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - thank you for your contribution!

I have left a few comments and suggestions about typing and code style

Excited to see Novita's text-to-video service on the platform!

@viktor2077
Copy link
Contributor Author

I have left a few comments and suggestions about typing and code style

Thanks @SBrandeis , these suggestions are detailed and helpful!

@hanouticelina hanouticelina added the inference-providers integration of a new or existing Inference Provider label May 20, 2025
@viktor2077 viktor2077 requested a review from SBrandeis May 21, 2025 02:12
SBrandeis
SBrandeis reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Apart from that typing issue, it looks good to me.
Don't forget to run pnpm format and pnpm lint in the packages/inference folder to conform our code quality checks.

@viktor2077 viktor2077 requested a review from SBrandeis May 22, 2025 12:44
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

SBrandeis
SBrandeis approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Defering to @hanouticelina for a second pair of eyes 👀
Thanks @viktor2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SBrandeis SBrandeis SBrandeis approved these changes

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@hanouticelina hanouticelina Awaiting requested review from hanouticelina hanouticelina is a code owner

Assignees
No one assigned
Labels
inference-providers integration of a new or existing Inference Provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viktor2077 @HuggingFaceDocBuilderDev @SBrandeis @hanouticelina