Track download stats for the ACE-Step repo. #1456
Conversation
DumoeDss
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
There was a problem hiding this comment.
Thanks for the PR @DumoeDss - few nits and we should be golden, I'm not sure why the library is set to diffusers in the repo: https://huggingface.co/ACE-Step/ACE-Step-v1-3.5B when it actually uses the acestep model library: https://github.com/ace-step/ACE-Step/blob/74121a5d8a9af2fd651ba70869e78868442f6329/infer.py#L4
let's fix that too please! 🙏
| @@ -1040,6 +1040,14 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
| countDownloads: `path:"model_vae_fp16.pt"`, | |||
| snippets: snippets.threedtopia_xl, | |||
| }, | |||
| acestep: { | |||
There was a problem hiding this comment.
this keyword should be present in the model metadata too here: https://huggingface.co/ACE-Step/ACE-Step-v1-3.5B
you can do so by adding this tag in the model README.
There was a problem hiding this comment.
I have added the 'acestep' tag to the model card metadata.
| repoName: "ACE-Step", | ||
| repoUrl: "https://github.com/ace-step/ACE-Step", | ||
| filter: false, | ||
| countDownloads: `path:"ace_step_transformer/diffusion_pytorch_model.safetensors"`, |
There was a problem hiding this comment.
perhaps easier would be that we track it via the config.json: https://huggingface.co/ACE-Step/ACE-Step-v1-3.5B/blob/main/config.json
There was a problem hiding this comment.
(tracking config.json is already the default behavior)
There was a problem hiding this comment.
The config.json I added later in the root directory wasn't actually used during model loading - the model kept using the config.json in the subfolder (e.g., ace_step_transformer/config.json). Since this PR might take longer to process, I temporarily added the config.json at the root level. However, it doesn't seem to have taken effect, as the model's download count remains at 0. (For context, our LoRA model has already reached 1.2k downloads since upload.)
No description provided.