Windows support for T2V scripts #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
approved these changes
Oct 19, 2024
| @@ -199,6 +198,26 @@ def log_validation( | |||
| return videos | |||
|
|
|||
|
|
|||
| class CollateFunction: | |||
There was a problem hiding this comment.
Inline function raised an error with pickle in windows, moving collate function to a class instances solves the issue.
|
@a-r-r-o-w I think it looks good. Will try it out and report back if I encounter any errors. |
Nojahhh
approved these changes
Oct 20, 2024
|
Thanks for all your help @Nojahhh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nojahhh Would you mind giving this a review? You've already fixed the dataset side of things with lambda pickling error, and this PR replaces the inline collate_fn with a class instance as per your PR #32 in the remaining scripts