Skip to content

add valid names to dataset docs #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

add valid names to dataset docs #318

merged 1 commit into from
Mar 11, 2025

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Mar 11, 2025 •
edited
Loading

I figured this might save people a few minutes of troubleshooting.

I would suggest, though, to allow any name through the dataset config json

a-r-r-o-w
a-r-r-o-w approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a-r-r-o-w a-r-r-o-w merged commit afc1179 into huggingface:main Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neph1 @a-r-r-o-w