Skip to content

Fix last_hidden_state slicing position in ModernBertForSequenceClassification #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whitebox2
Copy link

Problem

The shape of the tensor passed to the classifier is different.
Transformers: correctly uses the [CLS] token → shape (batch_size, hidden_size)
slices across the feature dimension → shape (batch_size, seq_len)

Suggestion

I would like to propose the following change.
before

let last_hidden_state = output.i((.., .., 0))?;

after

let last_hidden_state = output.i((.., 0, ..))?;

This selects the first token (i.e., [CLS]) across all samples , resulting in a shape of (batch_size, hidden_size)

issue

#3000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant