Fix last_hidden_state slicing position in ModernBertForSequenceClassification #3010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The shape of the tensor passed to the classifier is different.
Transformers: correctly uses the [CLS] token → shape (batch_size, hidden_size)
slices across the feature dimension → shape (batch_size, seq_len)
Suggestion
I would like to propose the following change.
before
let last_hidden_state = output.i((.., .., 0))?;
after
let last_hidden_state = output.i((.., 0, ..))?;
This selects the first token (i.e., [CLS]) across all samples , resulting in a shape of (batch_size, hidden_size)
issue
#3000