Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the maintainability of
candle-metal-kernels
I think it is about time we introduce abuild.rs
to the project.This won't necessarily affect performance, but it will let us reuse components between kernels. Like
get_strided_index
, mlx'sbfloat16
impl (when there is no native bfloat), etc.Starting with reduce kernels and iteratively adding more to
candle.metallib
.Note: When running
build.rs
I got an exciting new error.I solved it by simply running
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
.This should be documented somehow - but where? Should I add it to the error description? Or in the
README.md
perhaps?