Skip to content

Fix: Ensure environment variable values are case-insensitive in Accelerate #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025

Conversation

jp1924
Copy link
Contributor

@jp1924 jp1924 commented Aug 5, 2025

What does this PR do?

# YAML configuration that can be passed to TrlParser's parse_args_and_config
env:
  ACCELERATE_USE_FSDP: true
  FSDP_VERSION: 2
  FSDP_RESHARD_AFTER_FORWARD: true
  FSDP_STATE_DICT_TYPE: "FULL_STATE_DICT"
  FSDP_AUTO_WRAP_POLICY: "TRANSFORMER_BASED_WRAP"
  FSDP_CPU_RAM_EFFICIENT_LOADING: false
  FSDP_ACTIVATION_CHECKPOINTING: false

When passing ACCELERATE_USE_FSDP: true in the YAML config file and running the script, the os.environ.get("ACCELERATE_USE_FSDP", "false") == "true" condition in Accelerate does not activate FSDP due to receiving the value "True" (with uppercase "T").

To prevent this issue, all string values obtained via os.environ.get should be converted to lowercase using .lower().

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@SunMarc

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jp1924 jp1924 requested a review from SunMarc August 5, 2025 10:22
@SunMarc SunMarc merged commit 6640ff4 into huggingface:main Aug 5, 2025
25 checks passed
@jp1924
Copy link
Contributor Author

jp1924 commented Aug 5, 2025

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants