Fix: Ensure environment variable values are case-insensitive in Accelerate #3712
+19
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When passing
ACCELERATE_USE_FSDP: true
in the YAML config file and running the script, theos.environ.get("ACCELERATE_USE_FSDP", "false") == "true"
condition in Accelerate does not activate FSDP due to receiving the value"True"
(with uppercase "T").To prevent this issue, all string values obtained via
os.environ.get
should be converted to lowercase using.lower()
.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc