Fix failing tests

[msabramo]

It looks like the tests have been failing for a while, because of some issue with mock-adaptor and the latest version of hubot?

@michaelansel: Do you have recommendations for how @patcon can fix the tests?

It looks like https://github.com/michaelansel/hubot-approval/blob/master/test/approval-test.coffee is using a combination of chai, sinon, and sinon-chai. I don't know what those things are because I'm new to NodeJS, but I saw hubot-approval using them, so maybe they're the current state of the art?

[michaelansel]

Figuring out testing patterns is an open issue on the core: hubotio/hubot#985

Hopefully getting to it someday?

[patcon]

Thanks folks :) Sorry I can't sort it out myself, but happy to merge solutions

[patcon]

Re: @michaelansel #20 (comment)

Up to @patcon to decide how to handle failing tests for his project.

I'm actually hands-off on this project atm, so hoping someone who values testing can submit a PR for getting them up and running again :)

Also, totally willing to add that person who fixes up testing as a new collaborator