Update @rails/actioncable dependency to version >=7.0 #705
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienpoly
force-pushed
the
loosen-action-cable-version
branch
from
05af63b to
0850912
Compare
|
I think the CI failures are not directly linked to this PR and are addressed by #706 |
|
This includes changes to the app/js file. Take that's not intended? |
adrienpoly
force-pushed
the
loosen-action-cable-version
branch
3 times, most recently
from
cf4df1e to
0dcf22a
Compare
adrienpoly
force-pushed
the
loosen-action-cable-version
branch
from
468588b to
fbd4496
Compare
dhh
reviewed
Mar 4, 2025
| @@ -5533,12 +5533,11 @@ class ConnectionMonitor { | |||
| isRunning() { | |||
| return this.startedAt && !this.stoppedAt; | |||
| } | |||
| recordPing() { | |||
| recordMessage() { | |||
dhh
reviewed
Mar 4, 2025
| @@ -5737,6 +5736,7 @@ Connection.prototype.events = { | |||
| return; | |||
| } | |||
| const {identifier: identifier, message: message, reason: reason, reconnect: reconnect, type: type} = JSON.parse(event.data); | |||
| this.monitor.recordMessage(); | |||
|
Ah, so the code changes are actually pulled from the npm source? |
Yes these changes comes from the build process |
|
Is it possible to get a release with this change? The only workaround is to get @hotwired/turbo-rails from github main or a specific commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded to Rails 8.0 our app and noticed that we now have 2 versions of actioncable in our bundle due to the dependency of turbo-rails to actioncable ^7.0
This PR loosen the dependency to >=7.0