Ux improvements #362
Merged
Ux improvements #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the trailing content with icon is a waste of space for list item.
Also when the alert is not active, the happy face doesn't make sense to all users.
I want to refactor such that the warning icon overlaps with leading content icon.
----
I'll refactor the code to overlay the warning icon on top of the leading content icon when an alert is active, and remove the happy face icon completely when it's not active. This will save space in the list item.
Here's the implementation:
```kotlin
leadingContent = {
Box(contentAlignment = Alignment.Center) {
// Main category icon
Icon(
painter = painterResource(iconResId),
contentDescription = null,
tint = MaterialTheme.colorScheme.primary,
modifier = Modifier.size(48.dp),
)
// Conditionally show warning icon as an overlay when alert is active
if (data.isAlertActive) {
Icon(
painter = painterResource(R.drawable.warning_24dp),
contentDescription = "Alert active",
tint = MaterialTheme.colorScheme.error,
modifier = Modifier
.size(24.dp)
.align(Alignment.BottomEnd)
)
}
}
},
// Remove the trailingContent completely
```
This approach:
1. Uses a Box to layer the warning icon over the category icon
2. Shows the warning icon only when an alert is active
3. Positions the warning icon at the bottom-right of the category icon
4. Uses error color for the warning icon to make it stand out
5. Completely removes the trailing content and the happy face icon
You'll need to import `Box` and `contentAlignment` if not already imported:
```kotlin
import androidx.compose.foundation.layout.Box
```
…ing from without going to details
Code Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
CurrentAlertListScreen.ktfile and adds a new drawable resource. The most important changes include the addition of new imports, modifications to theCurrentWeatherAlertPresenterclass, updates to theAlertListItemfunction, and changes to theCurrentWeatherAlertsPreviewfunction.Changes to
CurrentAlertListScreen.kt:Imports:
Box,height, andserviceConfigto support new layout and configuration functionalities. [1] [2]BuildConfig.CurrentWeatherAlertPresenterclass:forecastSourceNameassignment by using theserviceConfigextension function.AlertListItemfunction:CurrentWeatherAlertsPreviewfunction:isAlertActiveproperty totruefor better preview representation.New drawable resource:
info_24dp.xml:AlertListItemfunction.