Skip to content

add floor column to datatable in config devices page #26103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

chrisv-dev
Copy link
Contributor

Proposed change

This PR adds a floor column to the config devices table, displaying the floor value for each listed device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion: Idea was mentioned in a comment here: #25979
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975
Copy link
Contributor

I am not sure about

filterable: true,

@MindFreeze
Copy link
Contributor

I am not sure about

filterable: true,

Floors do have names and it would be weird if you make the column visible but can't search on it, imo

@ildar170975
Copy link
Contributor

Agreed but may give confusing results in some cases; depends on particular naming may be… Imagine floors “1”, “2” and entities with digits.

@MindFreeze
Copy link
Contributor

Right but I wouldn't expect to get very specific results when searching for "2" anyway so should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants