Skip to content

Revert #25027 "more-info-camera: disable download_snapshot if idle" #25643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented May 29, 2025

Breaking change

Proposed change

In #25027 an additional check for "idle" was added.
Unfortunately:

  1. Even a disabled button can be pressed (this issue should be considered separately, can be common):
    изображение

  2. An "idle" camera can have an image:
    изображение

Revering that PR for a better solution.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze
Copy link
Contributor

Yeah, I too have cameras that are always "Idle" but show video

@MindFreeze MindFreeze merged commit b30fa12 into home-assistant:dev May 30, 2025
16 checks passed
@ildar170975
Copy link
Contributor Author

I think I will have to look to a core for that issue.
As for “disabled button can be pressed» - will check this too when be near PC again.

@MindFreeze
Copy link
Contributor

"disabled button can be pressed" is a known issue. We are currently updating all our buttons so this may be fixed soon

@ildar170975
Copy link
Contributor Author

Thanks a lot! I am missing a lot of interesting things here(((

@ildar170975 ildar170975 deleted the revert-camera branch May 30, 2025 11:29
@bramkragten bramkragten added this to the 2025.6 milestone May 30, 2025
bramkragten pushed a commit that referenced this pull request May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants