Skip to content

Add energy compare with previous year #25037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

karwosts
Copy link
Contributor

Proposed change

Add a toggle between comparing previous period and previous year.

I considered many different ways to approach this, e.g. if there should be another date picker, multiple preset options, compare with year-2 or year-3, etc, but eventually just decided to start with the most simple/limited possible implementation to get started. Am happy to do this a different way if we prefer a different UI. But from what comments I saw comparing with the previous year seemed to come up the most often as a request.

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@home-assistant home-assistant bot added cla-signed WTH Issues & PRs generated from the "Month of What the Heck?" labels Apr 13, 2025
@karwosts karwosts added the Needs UX Pull requests requiring a review from the Home Assistant design team label Apr 13, 2025
@Madelena
Copy link
Contributor

Hello @karwosts , I am working on a design for the calendar picker for comparison use. Would love to talk to you more about it over here or Discord.

@karwosts
Copy link
Contributor Author

Sure I'm happy to chat about it. Either here or maybe in the frontend project channel?

Flexibility of a calendar picker would be nice, though I'm a bit hesitant to introduce more usage of our current calendar given that it is not accessible, and several users have complained that they cannot use it. So I would feel bad to proliferate it further 😢

@boern99
Copy link
Contributor

boern99 commented May 20, 2025

Will this feature be implemented? It would be very valuable for me and certainly for others as well.

@bramkragten
Copy link
Member

bramkragten commented May 26, 2025

Sure I'm happy to chat about it. Either here or maybe in the frontend project channel?

Flexibility of a calendar picker would be nice, though I'm a bit hesitant to introduce more usage of our current calendar given that it is not accessible, and several users have complained that they cannot use it. So I would feel bad to proliferate it further 😢

Would something like https://github.com/WickyNilliams/cally (demo: https://wicky.nillia.ms/cally/) fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Needs UX Pull requests requiring a review from the Home Assistant design team WTH Issues & PRs generated from the "Month of What the Heck?"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants