-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Todo List Card: Add customization options for empty text, visibility, and interaction #24788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Todo List Card: Add customization options for empty text, visibility, and interaction #24788
Conversation
… list, and disabling edit on click
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Some comments from a UX perspective:
|
@MindFreeze, Thanks for the feedback! I like it. I plan to update to:
Watching my own family interact with the cards, these are things that I had to implement via card mod & a lot of effort. I also seen enough traffic on forums to know that these features are useful from a Ux point of view within common use cases like Chores Lists for kids. Great comment, to my eyes this will help a lot! |
@MindFreeze, I've updated the PR based on the feedback:
These changes maintain the same functionality but with clearer option names and better separation of concerns. |
Overview
This PR adds three new customization options to the Todo List card:
Configurable empty list text: Users can customize the message shown when there are no tasks by setting the
empty_list_text
property.Option to hide empty list message: Added a
hide_empty_list
property that, when set to true, completely hides the empty list message (including vertical space).Disable editor with click actions: Added a
disable_edit_on_click
property that prevents the editor from opening when clicking on an item. When this option is enabled, clicking on an item toggles its completion status instead. (Particularly good for re-usable lists like weekly chores)Why
These enhancements improve customization options for users who:
Testing
I've tested all three features in my local environment:
No performance issues or regressions were found.
Breaking Changes
None. These changes only add optional features that are disabled by default, maintaining backward compatibility.