Fix using "extractApiErrorMessage" in error-log-card w/o supervisor #24732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Mar 26, 2025
| @@ -21,12 +21,20 @@ export interface HassioStats { | |||
| export const hassioApiResultExtractor = <T>(response: HassioResponse<T>) => | |||
| response.data; | |||
|
|
|||
| export const extractApiErrorMessage = (error: any): string => | |||
| typeof error === "object" | |||
| export const extractApiErrorMessage = ( | |||
There was a problem hiding this comment.
This is code from the supervisor, it lives in data/hassio, if we want to make it more generic we should move it out of the code for supervisor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Currently
extractApiErrorMessagecontains a "supervisor" word which is confusing in case of some installation types.For example, this message was shown in HA in Container:
This PR fixes a use of
extractApiErrorMessageinerror-log-cardwhere this inconsistency was observed.WARNING: I cannot test this PR since cannot reproduce same error...
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: