Minor UI bugfixes for selector-datetime and dialog-date-picker #15759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karwosts
commented
Mar 7, 2023
| const y = today.getFullYear(); | ||
| const m = (today.getMonth() + 1 < 10 ? "0" : "") + (today.getMonth() + 1); | ||
| const d = (today.getDate() < 10 ? "0" : "") + today.getDate(); | ||
| this._value = y + "-" + m + "-" + d; |
There was a problem hiding this comment.
I contemplated putting this in format_date, but I couldn't think of a good name to give it, and didn't see it used elsewhere. I would have hoped there would be an easier standard way to get this format, but I couldn't find one.
karwosts
commented
Mar 7, 2023
karwosts
commented
Mar 7, 2023
| @value-changed=${this._valueChanged} | ||
| > | ||
| </ha-date-input> | ||
| <ha-time-input | ||
| enable-second | ||
| .value=${values?.[1] || "0:00:00"} | ||
| .value=${values?.[1] || "00:00:00"} |
There was a problem hiding this comment.
If pass "0:00:00" to time-input, it reformats it as "00:00:00" and fires an unwanted value-changed event.
karwosts
commented
Mar 7, 2023
bramkragten
reviewed
Mar 16, 2023
| @@ -72,7 +72,7 @@ export class HaDateTimeSelector extends LitElement { | |||
|
|
|||
| private _sendChangedEvent(): void { | |||
| fireEvent(this, "value-changed", { | |||
| value: `${this._dateInput.value} ${this._timeInput.value}`, | |||
| value: `${this._dateInput.value ?? ""} ${this._timeInput.value}`, | |||
There was a problem hiding this comment.
Should we not just only send a change event when we can send a valid value? So when we have both a date and time?
There was a problem hiding this comment.
Yes we can do that. Updated.
bramkragten
force-pushed
the
ui-date-bugfixes
branch
from
bcdadb7 to
c7e5399
Compare
bramkragten
approved these changes
May 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
A few miscellaneous bugfixes:
The date format for en-CA was recently changed from "yyyy-mm-dd" to "mm/dd/yyyy". This has broken the
todaybutton on the date picker, which relied on the specific en-CA format. It looks like it may change back in the future, but just change the code to format the date in the correct way as needed, rather than rely on the future politicial whims of Canadians.See ToLocaleDateString inconsistent/wrong output locale to "en-CA" nodejs/node#45945 and https://unicode-org.atlassian.net/browse/CLDR-16399 for more background.
When opening a date-picker-dialog with the value of undefined, it was not possible to select today's date without first clicking to a different date, and then clicking back on today. Fix this behavior.
The datetime selector has some problems, detailed in ha-selector-datetime broken in ha-service-control #15755, which are fixed here.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: