Skip to content

Replace abandoned cchardet library #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 15, 2023

cchardet is abandoned https://docs.aiohttp.org/en/stable/#library-installation PyYoshi/cChardet#77

There is a new active fork https://github.com/faust-streaming/cChardet that works on python3.11

home-assistant/core#88254 will remove the last lib that uses it from core which we can merge when we bump this.

@bdraco bdraco marked this pull request as draft February 15, 2023 14:05
bdraco added a commit to home-assistant/core that referenced this pull request Feb 16, 2023
@bdraco bdraco closed this Feb 16, 2023
@bdraco bdraco reopened this Feb 16, 2023
@bdraco bdraco marked this pull request as ready for review February 16, 2023 14:19
thecode pushed a commit to home-assistant/core that referenced this pull request Feb 16, 2023
balloob pushed a commit to home-assistant/core that referenced this pull request Feb 16, 2023
* Remove profiler.memory service

guppy3 is not python3.11 compat
zhuyifei1999/guppy3#41

This service will return if and when guppy3 becomes
python3.11 compat

* squash

* temp remove

* temp dump tests

* temp dump tests

* drop a few more to get a run

* drop a few more to get a run

* Account for changed python3.11 enum.IntFlag behavior in zha

There may be additional changes needed, but I could only
see what needed to be updated based on the tests

* merge

* restore

* restore

* legacy value

* tweak a bit for the python 3.11 timings

* block cchardet

* conditional

* adjust est

* test

* not yet

* tweak

* give a little leeway for timing

* Fix otbr tests

* Increase database test timeout

It looks like we need a little more time to run
with the addiitonal tests in #87019

* Increase database test timeout

It looks like we need a little more time to run
with the addiitonal tests in #87019

* Fix aprs tests with python 3.11

* merge fix

* hints

* Update homeassistant/package_constraints.txt

* Update script/gen_requirements_all.py

* Constrain uamqp for Python 3.10 only

* Bump vulcan-api to 2.3.0

see kapi2289/vulcan-api#126
see #88038
see home-assistant/docker#260

* add ban

* Bump python-matter-server to 2.1.1

* revert

* Update tests/asyncio_legacy.py

---------

Co-authored-by: Erik <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

@frenck
Copy link
Member

frenck commented Feb 17, 2023

Going to merge this in, overriding the CI failure (which are caused by this PR originating from a fork).

../Frenck

@frenck frenck merged commit cca674e into home-assistant:master Feb 17, 2023
AlePerla pushed a commit to AlePerla/homeassistant_core that referenced this pull request Feb 17, 2023
AlePerla pushed a commit to AlePerla/homeassistant_core that referenced this pull request Feb 17, 2023
* Remove profiler.memory service

guppy3 is not python3.11 compat
zhuyifei1999/guppy3#41

This service will return if and when guppy3 becomes
python3.11 compat

* squash

* temp remove

* temp dump tests

* temp dump tests

* drop a few more to get a run

* drop a few more to get a run

* Account for changed python3.11 enum.IntFlag behavior in zha

There may be additional changes needed, but I could only
see what needed to be updated based on the tests

* merge

* restore

* restore

* legacy value

* tweak a bit for the python 3.11 timings

* block cchardet

* conditional

* adjust est

* test

* not yet

* tweak

* give a little leeway for timing

* Fix otbr tests

* Increase database test timeout

It looks like we need a little more time to run
with the addiitonal tests in home-assistant#87019

* Increase database test timeout

It looks like we need a little more time to run
with the addiitonal tests in home-assistant#87019

* Fix aprs tests with python 3.11

* merge fix

* hints

* Update homeassistant/package_constraints.txt

* Update script/gen_requirements_all.py

* Constrain uamqp for Python 3.10 only

* Bump vulcan-api to 2.3.0

see kapi2289/vulcan-api#126
see home-assistant#88038
see home-assistant/docker#260

* add ban

* Bump python-matter-server to 2.1.1

* revert

* Update tests/asyncio_legacy.py

---------

Co-authored-by: Erik <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
@bdraco
Copy link
Member Author

bdraco commented Feb 21, 2023

https://github.com/faust-streaming/cChardet/releases/tag/v2.1.17
faust-streaming/cChardet#23

The new version is up which should fix the wheel builds
Test run is here https://github.com/home-assistant/core/actions/runs/4235156300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants