Skip to content

Add Oracle DB libraries #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add Oracle DB libraries #191

wants to merge 3 commits into from

Conversation

mciupak
Copy link
Contributor

@mciupak mciupak commented Jun 16, 2021

Following home-assistant/core#50090 I would like to add cx_oracle and Oracle Instant Client libraries to docker image to be able to use recorder with Oracle DB out of the box.

Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote against this contribution:

  • Licence issue
  • Binary blobs

If Oracle does his stuff opensource and releases an official alpine package, we can speak about it.

@frenck
Copy link
Member

frenck commented Jun 16, 2021

I agree on not adding it. I was looking at the same.

It will also add 30+ megabytes to every image we ship, while the effective use might be considered fairly minimal.

@mciupak
Copy link
Contributor Author

mciupak commented Jun 16, 2021

Understood, fair enough, then I got two ideas/questions:

  1. Can we add cx_oracle at least? Instant Client libraries are needed to access cloud based DB instances, but local instances does not require it and can be handled by sqlalchemy with cx_oracle only.
  2. Can we think about kind of additional secondary set of base image with Oracle binaries included anyhow?

@balloob
Copy link
Member

balloob commented Jun 16, 2021

I also agree on not adding it.

Local Oracle databases… if people pay for a DB like that, they can maintain their own images. Not something we want to maintain.

@balloob balloob closed this Jun 16, 2021
@pvizeli
Copy link
Member

pvizeli commented Jun 16, 2021

Using the python package is fine for me

@mciupak mciupak mentioned this pull request Jun 16, 2021
@ryansun96
Copy link

I also agree on not adding it.

Local Oracle databases… if people pay for a DB like that, they can maintain their own images. Not something we want to maintain.

@balloob Actually Oracle now offers (always) free database instances in their oracle cloud free tier with a 20GB storage quota. So folks (including me) who want to use Oracle with their HA might not necessarily be big corporations...

@balloob
Copy link
Member

balloob commented Jun 26, 2021

See the activity entry right above your comment. It's been added.

@ryansun96
Copy link

I'm talking about client libraries.

@pvizeli
Copy link
Member

pvizeli commented Jun 27, 2021

We only allow install open-source packages. No way to add this client and no plan to make different images

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants