-
Notifications
You must be signed in to change notification settings - Fork 87
Add Oracle DB libraries #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote against this contribution:
- Licence issue
- Binary blobs
If Oracle does his stuff opensource and releases an official alpine package, we can speak about it.
I agree on not adding it. I was looking at the same. It will also add 30+ megabytes to every image we ship, while the effective use might be considered fairly minimal. |
Understood, fair enough, then I got two ideas/questions:
|
I also agree on not adding it. Local Oracle databases… if people pay for a DB like that, they can maintain their own images. Not something we want to maintain. |
Using the python package is fine for me |
@balloob Actually Oracle now offers (always) free database instances in their oracle cloud free tier with a 20GB storage quota. So folks (including me) who want to use Oracle with their HA might not necessarily be big corporations... |
See the activity entry right above your comment. It's been added. |
I'm talking about client libraries. |
We only allow install open-source packages. No way to add this client and no plan to make different images |
Following home-assistant/core#50090 I would like to add cx_oracle and Oracle Instant Client libraries to docker image to be able to use recorder with Oracle DB out of the box.