Skip to content

Update pyfido to 2.1.2 #88343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Update pyfido to 2.1.2 #88343

merged 1 commit into from
Feb 17, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 17, 2023

Proposed change

Updates pyfido to 2.1.2, which removes the deprecated asyncio coroutine decorator.
Upstream PR: titilambert/pyfido#5

It consists of a single PR: titilambert/pyfido@d8dd6e8

There is no changelog, or tag to point too. The integration is also unused (according to stats)
The author of the integration library advised to deprecated the integration.

This PR is still here to fix compatibility issues for newer Python versions (3.11).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco mentioned this pull request Feb 17, 2023
53 tasks
@frenck frenck merged commit 26f0de0 into dev Feb 17, 2023
@frenck frenck deleted the frenck-2023-0318 branch February 17, 2023 18:51
AlePerla pushed a commit to AlePerla/homeassistant_core that referenced this pull request Feb 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants