Add sensors to ntfy integration #145262
Open
Add sensors to ntfy integration #145262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
joostlek
requested changes
May 20, 2025
Comment on lines
+98
to
+103
| NtfySensorEntityDescription( | ||
| key=NtfySensor.EMAILS_REMAINING, | ||
| translation_key=NtfySensor.EMAILS_REMAINING, | ||
| value_fn=lambda account: account.stats.emails_remaining, | ||
| entity_registry_enabled_default=False, | ||
| ), |
There was a problem hiding this comment.
I would argue that remaining also is diagnostic
There was a problem hiding this comment.
well, they are the invert of their respective sensors like NtfySensor.EMAILS and change at the same time. The limit entities on the other hand are quite static, they change based on the subscription tier, therefore i put them in diagnostics. I wasn't even sure if I should add them or not, but i decided to include them as deactivated by default. If you decide they are diagnostic entities or if they are not useful and should be removed, I'm ok with both.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The service itself is added as device and provides various sensors showing usage statistics and usage limits for your account (based on IP if unauthenticated)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: