Skip to content

Make sure SmartThings light can deal with unknown states #140190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2025
Merged

Make sure SmartThings light can deal with unknown states #140190

merged 5 commits into from
Mar 11, 2025

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Mar 9, 2025

Proposed change

Make sure SmartThings light can deal with null values. As apparently there are devices that have that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2025.3.2 milestone Mar 9, 2025
jbouwh
jbouwh approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should add a little not to explain why we return 0.0.

LGTM,
Thanks @joostlek 👍

MartinHjelmare
MartinHjelmare requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above.

@home-assistant home-assistant bot marked this pull request as draft March 11, 2025 13:12
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek changed the title Make sure SmartThings light can deal with null values Make sure SmartThings light can deal with unknown states Mar 11, 2025
@joostlek
Merge branch 'dev' into st-light-none
0f9a030 
# Conflicts:
#	tests/components/smartthings/conftest.py
@joostlek joostlek marked this pull request as ready for review March 11, 2025 13:21
@home-assistant home-assistant bot requested a review from MartinHjelmare March 11, 2025 13:21
MartinHjelmare
MartinHjelmare approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

frenck
frenck approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@joostlek joostlek merged commit 5361092 into home-assistant:dev Mar 11, 2025
34 checks passed
@joostlek joostlek deleted the st-light-none branch March 11, 2025 13:47
@bapesupreme
Copy link

Is there a way for me to test without waiting for the next release?

@joostlek
Copy link
Member Author

Yes there is, but the release will most likely be sooner than we can it testable :)

@frenck frenck modified the milestone: 2025.3.2 Mar 11, 2025
frenck pushed a commit that referenced this pull request Mar 11, 2025
@joostlek @frenck
Make sure SmartThings light can deal with unknown states (#140190)
b5c7bdd 
* Fix

* add comment

* Make light unknown

* Make light unknown
@frenck frenck mentioned this pull request Mar 11, 2025
Merged
frenck added a commit that referenced this pull request Mar 11, 2025
@frenck @emontnemery
@moosilauke18 @jrhillery @kbickar @zxdavb @andrewsayre @joostlek @jbouwh @msm595 @tr4nt0r @jpbede @Diegorro98 @MartinHjelmare @Lash-L @epenet @cereal2nd @crevetor @puddly @dknowles2 @Bre77 @PeteRager
2025.3.2 (#140392)
a12915f 
* Don't allow creating backups if Home Assistant is not running (#139499)

* Don't allow creating backups if hass is not running

* Revert "Don't allow creating backups if hass is not running"

This reverts commit 1bf545e.

* Set backup manager to idle only after Home Assistant has started

* Update according to discussion, add tests

* Add more test

* Bump govee_ble to 0.43.1 (#139862)

Bump govee_ble to 0.43.0

* Label emergency heat switch (#139872)

* Add label to emergency heat switch

* Use sentence case names

Co-authored-by: Franck Nijhof <[email protected]>

---------

Co-authored-by: Franck Nijhof <[email protected]>

* Bump sense-energy lib to 0.13.7 (#140068)

* Update jinja to 3.1.6 (#140069)

* Update evohome-async to 1.0.3 (#140083)

bump client to 1.0.3

* Fix HEOS discovery error when previously ignored (#140091)

Abort ignored discovery

* Map prewash job state in SmartThings (#140097)

* Check support for thermostat operating state in SmartThings (#140103)

* Handle None options in SmartThings (#140110)

* Handle None options in SmartThings

* Handle None options in SmartThings

* Fix MQTT JSON light not reporting color temp status if color is not supported (#140113)

* Fix HEOS user initiated setup when discovery is waiting confirmation (#140119)

* Support null supported Thermostat modes in SmartThings (#140101)

* Set device class for Oven Completion time in SmartThings (#140139)

* Revert "Check if the unit of measurement is valid before creating the entity" (#140155)

Revert "Check if the unit of measurement is valid before creating the entity …"

This reverts commit 99e1a7a.

* Fix the order of the group members attribute of the Music Assistant integration (#140204)

* Fix events without user in Bring integration (#140213)

Fix events without publicUserUuid

* Log broad exception in Electricity Maps config flow (#140219)

* Bump evohome-async to 1.0.4 to fix  #140194 (#140230)

bump client, add test for fix  #140194

* Refresh Home Connect token during config entry setup (#140233)

* Refresh token during config entry setup

* Test 500 error

---------

Co-authored-by: Martin Hjelmare <[email protected]>

* Add 900 RPM option to washer spin speed options at Home Connect (#140234)

Add 900 RPM option to washer spin speed options

* Fix todo tool broken with Gemini 2.0 models. (#140246)

* Change tool name for addlist item

* Change to HasListAddItem

* extract to function

* Fix version not always available in onewire (#140260)

* Fix `client_id` not generated when connecting to the MQTT broker (#140264)

Fix client_id not generated when connecting to the MQTT broker

* Bump velbusaio to 2025.3.0 (#140267)

* Fix dryer operating state in SmartThings (#140277)

* FGLair : Upgrade to ayla-iot-unofficial 1.4.7 (#140296)

Upgrade to ayla-iot-unofficial 1.4.7

* Bump pyheos to v1.0.3 (#140310)

Bump pyheos v1.0.3

* Bump ZHA to 0.0.52 (#140325)

* Bump pydrawise to 2025.3.0 (#140330)

* Bump teslemetry-stream (#140335)

Bump

* Fix no temperature unit in SmartThings (#140363)

* Fix double space quoting in WebDAV (#140364)

* Bump python-roborock to 2.12.2 (#140368)

bump python roboorck to 2.12.2

* Handle incomplete power consumption reports in SmartThings (#140370)

* Fix browsing Audible Favorites in Sonos (#140378)

* initial commit

* updates

* update test data

* Make sure SmartThings light can deal with unknown states (#140190)

* Fix

* add comment

* Make light unknown

* Make light unknown

* Delete subscription on shutdown of SmartThings (#140135)

* Cache subscription url in SmartThings

* Cache subscription url in SmartThings

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Bump pysmartthings to 2.7.1

* 2.7.2

---------

Co-authored-by: Martin Hjelmare <[email protected]>

* Bump version to 2025.3.2

---------

Co-authored-by: Erik Montnemery <[email protected]>
Co-authored-by: Evan Farrell <[email protected]>
Co-authored-by: John Hillery <[email protected]>
Co-authored-by: Keilin Bickar <[email protected]>
Co-authored-by: David Bonnes <[email protected]>
Co-authored-by: Andrew Sayre <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Jan Bouwhuis <[email protected]>
Co-authored-by: msm595 <[email protected]>
Co-authored-by: Manu <[email protected]>
Co-authored-by: Jan-Philipp Benecke <[email protected]>
Co-authored-by: J. Diego Rodríguez Royo <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Luke Lashley <[email protected]>
Co-authored-by: epenet <[email protected]>
Co-authored-by: Maikel Punie <[email protected]>
Co-authored-by: Antoine Reversat <[email protected]>
Co-authored-by: puddly <[email protected]>
Co-authored-by: David Knowles <[email protected]>
Co-authored-by: Brett Adams <[email protected]>
Co-authored-by: Pete Sage <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@jbouwh jbouwh jbouwh approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: smartthings Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.3.2
Development

Successfully merging this pull request may close these issues.

Juno Connect Wafer LEDs not working with SmartThings
5 participants
@joostlek @bapesupreme @frenck @MartinHjelmare @jbouwh