Skip to content

Avoid collision when replacing existing config entry with same unique id #130062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

emontnemery
Copy link
Contributor

Proposed change

Avoid intermittent collision when replacing existing config entry with same unique id

This is required before we can disallow config entry unique id collisions

Extracted from PR #127409

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner November 7, 2024 16:33
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Nov 7, 2024
@emontnemery emontnemery merged commit 2b7d593 into dev Nov 8, 2024
42 checks passed
@emontnemery emontnemery deleted the config_entry_avoid_collision_on_replace branch November 8, 2024 06:45
@epenet
Copy link
Contributor

epenet commented Nov 8, 2024

Side note: I'm still confused that creating a config entry with the same unique id overwrites the previous config entry!
I know it's the existing behavior, but should it not at least log a warning?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still true?

# We will remove it only after the other one is set up,
# so that device customizations are not getting lost.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
@emontnemery
Copy link
Contributor Author

Is this comment still true?

# We will remove it only after the other one is set up,
# so that device customizations are not getting lost.

Fixed by #131175

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants