Skip to content

Add check for decodeFromString in MissingSerializableAnnotation lint rule #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TimoPtr
Copy link
Collaborator

@TimoPtr TimoPtr commented May 28, 2025

Summary

Extend our current lint rule for detecting missing Serializable annotation introduce in #5368 to detect missing annotation in decodeFromString invocations.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

image
image

Any other notes

An issue has been open on the official repo Kotlin/kotlinx.serialization#3010 to see if they can do something about it.

@jpelgrom
Copy link
Member

There is a TODO and commented out code. Are you still planning to do that in this PR? I have no idea how much work that would be so can't really guess.

@TimoPtr
Copy link
Collaborator Author

TimoPtr commented May 29, 2025

There is a TODO and commented out code. Are you still planning to do that in this PR? I have no idea how much work that would be so can't really guess.

It's a leftover.... I handled this cases already and the dead code needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants