Skip to content

Improve edge to edge support in settings #5374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025

Conversation

TimoPtr
Copy link
Collaborator

@TimoPtr TimoPtr commented May 28, 2025

Summary

This PR makes sure that all the snackbar are properly displayed above the navigation bar. Since we've recently introduced the new function safeBottom/TopWindowInsets I've replaced all the usages that we had in the settings screen.

NfcSetupActivity was not supporting edge-to-edge, it has been fixed in this PR too.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

Part of #5328
Fixes #5357

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snackbars look good.


When testing in landscape a lot of settings screen seem to have double horizontal padding now for the content/list, for example:

Screenshot of the sensors list in landscape. The tap highlight for a row is active, showing that there is more padding to the left and right of the row than required.


This PR has a merge conflict.

@TimoPtr TimoPtr requested a review from jpelgrom June 2, 2025 21:21
@TimoPtr TimoPtr merged commit 5b4c814 into main Jun 3, 2025
33 of 34 checks passed
@TimoPtr TimoPtr deleted the feature/edge-to-edge-second-batch branch June 3, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snackbars in settings may be obscured by system UI
2 participants