fix: PolyEdit stream not synchronizes with CDS #6534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikalaiPrakapenka
force-pushed
the
fix/polyedit_stream_should_synchronize_data_with_cds
branch
from
91c2db5 to
dfad03b
Compare
Fixes holoviz#6532 In case of using PolyEdit tool value[2] is a list of lists or numpy arrays, not a str.
MikalaiPrakapenka
force-pushed
the
fix/polyedit_stream_should_synchronize_data_with_cds
branch
from
dfad03b to
0e9ad85
Compare
MikalaiPrakapenka
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6534 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 323 323
Lines 68955 68961 +6
=======================================
+ Hits 61229 61235 +6
Misses 7726 7726 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for the PR. Really nice you added a test! 👍 |
hoxbro
pushed a commit
that referenced
this pull request
Mar 13, 2025
Thank you |
MikalaiPrakapenka
deleted the
fix/polyedit_stream_should_synchronize_data_with_cds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6532
In case of using PolyEdit tool value[2] is a list of lists or numpy arrays, not a str.