Resume logs on failure and restart #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two previous methods of determining where to restart a log stream do not work well enough. Using the container start time sometimes skip the first logs, using the latest stop time sometimes include logs from previous run that were already printed. So this new method keeps track of which logs are already printed and skips them. It stores the printed log's timestamp and the number of logs printed on that timestamp. This introduces a new order dependency though. If a container delete event is handled before the log stream of said container terminates it will add an entry to the `seenContainers` cache even though the container does not exist. Haven't seen that happen though and the only downside is it might evict containers from that cache that still exist.
Had to move the log request to Start in order to inject the log stream to consumeStream.
hogklint
force-pushed
the
feat/retry-failed-tails
branch
from
ac3911e to
75c2235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.