-
Notifications
You must be signed in to change notification settings - Fork 0
docs: troubleshooting install issues #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @oli-hivemq,
Thank you for adding this, it definitely would save a lot of new users some time.
However, I think using .npmc might expose the user's token into git unless it is used through an environment variable (which might complicate things) for the CI build, or removed from git which is another using too.
Saving the token in their .bashrc
or .zshrc
might be another option
What do you think?
If this meant to solve issues on CI/Jenkins side:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minute request:
can we rename NPM_TOKEN
to GH_NPM_TOKEN
(GH stands for github) because there could be more package hosting repos down the road and it makes it more clear.
@antpaw Can you kindly clarify what you mean by this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@antpaw what about splitting step 2 (currently about saving the token in an env variable) into 2 paths:
|
@tolumq @oli-hivemq what I essentially mean is that https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#considering-cross-repository-access gihub refers to it as |
I see. That's a good point. In this case, what the doc could say is:
UI_THEME_NPM_TOKEN=YOUR_GENERATED_TOKEN
//npm.pkg.github.com/:_authToken=${UI_THEME_NPM_TOKEN} Or keep it as it is and add a note to the doc mentioning your point @antpaw |
We will have more packages that are shared, UIShell has a package, XSD-Forms is a package. Creating the same token with different var names feels "off," i rather keep it as is. |
Add a troubleshooting section for authorization issues when trying to install this library from another repo.