Skip to content

refactor / CLOUD-28090 / update colors and headings fontWeight #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2024
Merged

refactor / CLOUD-28090 / update colors and headings fontWeight #32

merged 2 commits into from
Nov 20, 2024

Conversation

oli-hivemq
Copy link
Collaborator

@oli-hivemq oli-hivemq commented Nov 20, 2024 •
edited
Loading

What

  • Fix Headings' font weight (800 -> 700)
    CleanShot 2024-11-20 at 11 07 34
  • Increase h3 font-size and line-height:
Before After
font-size 18px 24px
line-height 24px 32px

CleanShot 2024-11-20 at 11 13 41

  • Fix colors to use Chakra's 50->950 numbering by matching the changes on Figma in the Foundations file
    CleanShot 2024-11-20 at 11 08 35
    CleanShot 2024-11-20 at 11 11 15

Todos

  • I have added a description to this pull request that describes the changes in detail
  • I have performed a self-review of my code
  • I have added a label that describes the PR type (bug, enhancement, ci, refactor, documentation, test, chore)
  • I have added customer-facing 🙋‍♂️ label if this PR ships customer value
  • I have updated the optional PR title to follow the pattern Fix / TICKET_ID / DESCRIPTION (e.g. Fix / 123456 / Fixing the login button)
  • I have run manual tests to check if everything is functional
  • I have added screenshots/videos that explain my graphical changes

@oli-hivemq oli-hivemq added the enhancement New feature or request label Nov 20, 2024
@oli-hivemq oli-hivemq self-assigned this Nov 20, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2024
@oli-hivemq oli-hivemq requested review from RobinAtherton, antpaw and h2xd and removed request for antpaw and h2xd November 20, 2024 10:10
h2xd
h2xd approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@h2xd h2xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐊

@oli-hivemq oli-hivemq merged commit 1df7b82 into main Nov 20, 2024
5 checks passed
@oli-hivemq oli-hivemq deleted the fix/CLOUD-28090/headings-and-colors branch November 20, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h2xd h2xd h2xd approved these changes

@RobinAtherton RobinAtherton Awaiting requested review from RobinAtherton

@antpaw antpaw Awaiting requested review from antpaw antpaw is a code owner

Assignees

@oli-hivemq oli-hivemq

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oli-hivemq @h2xd