Skip to content

fix / CLOUD-25855 / exports #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix / CLOUD-25855 / exports #28

merged 1 commit into from
Sep 5, 2024

Conversation

oli-hivemq
Copy link
Collaborator

Why

Exports were changed in v0.4.1 and it's breaking the build of other projects trying to import components, colors, fonts or styles.
e.g.

import { colors, components, styles, fonts } from '@hivemq/ui-theme'

What

  • export theme as default
  • re-export components, colors, fonts and styles
  • also export semanticTokens

Todos

  • I have added a description to this pull request that describes the changes in detail
  • I have performed a self-review of my code
  • I have added a label that describes the PR type (bug, enhancement, ci, refactor, documentation, test, chore)
  • I have updated the optional PR title to follow the pattern Fix / TICKET_ID / DESCRIPTION (e.g. Fix / 123456 / Fixing the login button)
  • I have run manual tests to check if everything is functional
  • I have added screenshots/videos that explain my graphical changes

Screenshots

@oli-hivemq oli-hivemq added the bug Something isn't working label Sep 4, 2024
@oli-hivemq oli-hivemq self-assigned this Sep 4, 2024
@oli-hivemq oli-hivemq merged commit 250e34c into main Sep 5, 2024
6 checks passed
@oli-hivemq oli-hivemq deleted the fix/CLOUD-25855/exports branch September 5, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants