fix / CLOUD-25242 / definition of foundation and semantic colors #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add unit tests
oli-hivemq
commented
Aug 27, 2024
.github/workflows/build.yml
Outdated
There was a problem hiding this comment.
Changed default spacing from 4 to 2 characters
oli-hivemq
commented
Aug 27, 2024
Comment on lines
+59
to
+62
| <ColorModeProvider | ||
| value="dark" | ||
| options={{ useSystemColorMode: false, initialColorMode: 'dark' }} | ||
| > |
There was a problem hiding this comment.
This is the equivalent of <DarkMode>, but I wanted to show different ways of achieving the same thing
oli-hivemq
commented
Aug 27, 2024
Comment on lines
+4
to
+5
| default: string | ||
| _dark: string |
There was a problem hiding this comment.
This is the type Chakra uses internally (default for light mode, _dark for dark mode). By sticking to this convention, it makes the semantic color coding much simpler, without requiring any conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The semantic colors layer is not defined properly, which means that:
Done
Demo
Short video (when played at 1.5x speed) explaining the changes.
Screenshots