Skip to content

feat: Allow -fips Versions of teleport-ent cli #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drootsad
Copy link

@drootsad drootsad commented May 1, 2025

feat:
Allow installing of -fips versions of teleport cli.

resolves:
#37

testing:
I attempted testing, however the asdf plugin test functionality seems broken in the latest asdf tool version (I'm using asdf v0.16.7) and does not want to accept my parameters for testing installation of various tool versions... tried a whole lot of different combinations (with and without quotes, various syntaxes, setting env vars) that all failed to try and test any other version besides an antique one... hopefully the git pr workflow can run some tests? Or if someone can point me to what I'm doing wrong as far as trying to test?

$ asdf plugin test v6 https://github.com/drootsad/asdf-teleport-ent.git "tsh version" --asdf-tool-version "17.4.2-fips" --asdf-plugin-gitref "feat-fips"
* Downloading teleport-ent release 0.0.11...
curl: (22) The requested URL returned error: 404
asdf-teleport-ent: Could not download https://cdn.teleport.dev/teleport-ent-v0.0.11-linux-amd64-bin.tar.gz
FAILED: install exited with an error

$ asdf plugin test v1 https://github.com/drootsad/asdf-teleport-ent.git --asdf-tool-version 17.4.2 --asdf-plugin-gitref feat-fips "tsh version"

* Downloading teleport-ent release 0.0.11...
curl: (22) The requested URL returned error: 404
asdf-teleport-ent: Could not download https://cdn.teleport.dev/teleport-ent-v0.0.11-linux-amd64-bin.tar.gz
FAILED: install exited with an error

@drootsad
Copy link
Author

drootsad commented May 1, 2025

I was able to get some testing done via:

  • Installing my plugin from my own repo
  • Updating my plugin to this feature branch
    • asdf plugin update <commit hash> didn't seem to work... it pulled changes from the commit and staged them, but they weren't applied to the actual files on disk... I had to manually go into the plugin's folder, checkout main and then checkout my feature branch manually
  • Running some install commands for both -fips and non-fips versions
  • Verify install works and versions are correct
$ asdf install ddtest 17.4.2-fips
* Downloading teleport-ent release 17.4.2 (fips=true)...
teleport-ent 17.4.2-fips installation was successful!

$ asdf install ddtest 15.0.0
* Downloading teleport-ent release 15.0.0 (fips=false)...
teleport-ent 15.0.0 installation was successful!
$ asdf list ddtest
  15.0.0
  17.4.2-fips
$ /home/ddastoor/.asdf/installs/ddtest/15.0.0/bin/tsh version
Teleport v15.0.0 git:v15.0.0-0-ge126e8cd go1.21.6

$ /home/ddastoor/.asdf/installs/ddtest/17.4.2-fips/bin/tsh version
Teleport v17.4.2 git:v17.4.2-0-gcd8f06a go1.23.7 X:boringcrypto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant