Replace Grizzly HTTP Server with Java HTTP Server #1010
Conversation
|
|
||
|
|
||
| private File docRoot ; | ||
| private com.sun.net.httpserver.HttpServer httpServer; |
There was a problem hiding this comment.
Jikes... com.sun.net... As far as I remember, wasn't it an antipattern to depend on anything in com.sun as this is not guaranteed to be present in other JVMs.
There was a problem hiding this comment.
Scratch that, I've read up on it... Seems that I'm confusing sun.* and com.sun.*... Nothing to see here, thanks for the PR
There was a problem hiding this comment.
Thanks for reviewing and merging @hierynomus! Yes, the package name for the JDK HttpServer causes a natural double take, so thanks for giving it a closer look, as it is part of the public JDK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1010 +/- ##
============================================
+ Coverage 69.75% 70.54% +0.78%
- Complexity 1501 1544 +43
============================================
Files 214 215 +1
Lines 7681 7914 +233
Branches 663 682 +19
============================================
+ Hits 5358 5583 +225
+ Misses 1979 1977 -2
- Partials 344 354 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request replaces the Grizzly HTTP Server dependency with the standard Java HttpServer for port forwarding unit tests.
The Java HttpServer is part of the standard JDK since Java 1.6 and requires no external dependencies.