fix: enhance profile manager to take mirror node component overrides to increase pipeline stability #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jeromy-cannon merged 1 commit into main from mirror-node-test-fix

May 10, 2024

Contributor

jeromy-cannon commented May 10, 2024 •

edited

Loading

Description

This pull request changes the following:

for local profile add the following for mirror node grpc, rest, and web3 overrides:

readinessProbe:
  failureThreshold: 60
livenessProbe:
  failureThreshold: 60

enhance profile manager to set chart items for any subpath instead of only resources and hardware

Related Issues

Closes mirror_node.test.mjs fails often with timeouts in the CI pipeline #290


          enhance to handle liveness probe and readiness probe failure threshol…

56735e0

…d values file overrides for mirror node components

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon self-assigned this

Contributor

github-actions bot commented May 10, 2024

Unit Test Results - Windows

1 files ±0 18 suites ±0 1m 24s ⏱️ -19s
118 tests ±0 118 ✅ ±0 0 💤 ±0 0 ❌ ±0
143 runs ±0 143 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 56735e0. ± Comparison against base commit e6d79a6.

Contributor

github-actions bot commented May 10, 2024

Unit Test Results - Linux

1 files ±0 18 suites ±0 2m 1s ⏱️ +40s
118 tests ±0 118 ✅ ±0 0 💤 ±0 0 ❌ ±0
143 runs ±0 143 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 56735e0. ± Comparison against base commit e6d79a6.

Contributor

github-actions bot commented May 10, 2024

E2E Relay Tests Coverage Report

1 files ±0 1 suites ±0 2m 35s ⏱️ -49s
5 tests ±0 5 ✅ ±0 0 💤 ±0 0 ❌ ±0
6 runs ±0 6 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 56735e0. ± Comparison against base commit e6d79a6.

Contributor

github-actions bot commented May 10, 2024

E2E Mirror Node Tests Coverage Report

7 tests ±0 7 ✅ ±0 3m 22s ⏱️ -54s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 56735e0. ± Comparison against base commit e6d79a6.

Contributor

github-actions bot commented May 10, 2024

E2E Tests Coverage Report

55 tests ±0 55 ✅ ±0 4m 20s ⏱️ +23s
9 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 56735e0. ± Comparison against base commit e6d79a6.

Contributor

github-actions bot commented May 10, 2024

E2E Node Tests Coverage Report

1 files ±0 1 suites ±0 12m 20s ⏱️ + 9m 52s
34 tests - 1 34 ✅ +32 0 💤 - 27 0 ❌ - 6
38 runs ±0 38 ✅ +36 0 💤 - 31 0 ❌ - 5

Results for commit 56735e0. ± Comparison against base commit e6d79a6.

This pull request removes 1 test.

 Test execution failure: could be caused by test hooks like 'afterAll'. ‑  Test execution failure: could be caused by test hooks like 'afterAll'.

codacy-production bot commented May 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `e6d79a6`¹	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`e6d79a6`)	Report Missing	Report Missing	Report Missing
Head commit (`56735e0`)	3173	2581	81.34%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#289)	20	20	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov bot commented May 10, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.20%. Comparing base (a08c52f) to head (56735e0).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   81.25%   81.20%   -0.06%     
==========================================
  Files          33       33              
  Lines        3772     3767       -5     
  Branches      685      683       -2     
==========================================
- Hits         3065     3059       -6     
- Misses        707      708       +1

Files	Coverage Δ
src/core/profile_manager.mjs	`97.26% <100.00%> (-0.10%)`	⬇️

... and 1 file with indirect coverage changes

jeromy-cannon requested a review from JeffreyDallas

May 10, 2024 16:23

jeromy-cannon marked this pull request as ready for review

May 10, 2024 16:23

jeromy-cannon requested review from a team and leninmehedy as code owners

May 10, 2024 16:23

jeromy-cannon requested a review from nathanklick

May 10, 2024 16:23

nathanklick approved these changes

View reviewed changes

jeromy-cannon merged commit c89a042 into main

28 checks passed

jeromy-cannon deleted the mirror-node-test-fix branch

May 10, 2024 16:37

swirlds-automation added a commit that referenced this pull request


          chore(release): 0.25.0 [skip ci]

1212e2d

## [0.25.0](v0.24.0...v0.25.0) (2024-05-16)

### Features

* ability to deploy different software package to a subset of nodes ([#232](#232)) ([5e95030](5e95030))
* add `solo node add` subcommand ([#234](#234)) ([8cc3802](8cc3802))

### Bug Fixes

* enhance profile manager to take mirror node component overrides to increase pipeline stability ([#289](#289)) ([c89a042](c89a042))
* increase wait time for when recycling an haproxy pod for a node ([#292](#292)) ([cb5a1c6](cb5a1c6))
* jsdoc could not recognizing Promise<[*]> ([#275](#275)) ([9a9c00c](9a9c00c))
* revert to sleep and remove jest.runAllTicks from e2e test ([#255](#255)) ([a7cf6bf](a7cf6bf))
* use latest FST chart and a single consensus node during mirror-node e2e test ([#264](#264)) ([5a5a02f](5a5a02f))

Contributor

swirlds-automation commented May 16, 2024

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels