Skip to content

chore: improve .npmignore #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 14, 2025
Merged

chore: improve .npmignore #2243

merged 5 commits into from
Jul 14, 2025

Conversation

instamenta
Copy link
Contributor

Description

Related Issues

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

The following manual testing was done:

  • TBD

The following was not tested:

  • TBD
Commit message guidelines We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:
  1. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
  2. The title is prefixed with one of the following:
Prefix Description Semantic Version Update Captured in Release Notes
feat: a new feature MINOR Yes
fix: a bug fix PATCH Yes
perf: performance PATCH Yes
refactor: code change that isn't feature or fix none No
test: adding missing tests none No
docs: changes to documentation none Yes
build: changes to build process none No
ci: changes to CI configuration none No
style: formatting, missing semi-colons, etc none No
chore: updating grunt tasks etc; no production code change none No

@instamenta
improve .npmignore
f50409d 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta self-assigned this Jul 2, 2025
@instamenta instamenta linked an issue Jul 2, 2025 that may be closed by this pull request
go through and see what NPM is installing with Solo and perhaps there is more to add to .npmignore #1072
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

Unit Test Results - Linux

32 tests  ±0   32 ✅ ±0   0s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 0c9330c. ± Comparison against base commit b6763e4.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0  122 suites  ±0   4s ⏱️ ±0s
372 tests ±0  372 ✅ ±0  0 💤 ±0  0 ❌ ±0 
376 runs  ±0  376 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0c9330c. ± Comparison against base commit b6763e4.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

E2E Test Report

 18 files  ±0  128 suites  ±0   1h 52m 46s ⏱️ -48s
338 tests ±0  338 ✅ ±0  0 💤 ±0  0 ❌ ±0 
351 runs  ±0  351 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f50409d. ± Comparison against base commit 641a688.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

E2E Test Report

 19 files  134 suites   1h 52m 20s ⏱️
353 tests 353 ✅ 0 💤 0 ❌
366 runs  366 ✅ 0 💤 0 ❌

Results for commit 0c9330c.

♻️ This comment has been updated with latest results.

@codacy-production Codacy Production
Copy link

codacy-production bot commented Jul 2, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b6763e41 ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b6763e4) Report Missing Report Missing Report Missing
Head commit (0c9330c) 38286 32469 84.81%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2243) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

jeromy-cannon
jeromy-cannon reviewed Jul 2, 2025
View reviewed changes
instamenta added 2 commits July 4, 2025 10:30
@instamenta
Merge remote-tracking branch 'origin/main' into 1072-go-through-and-s…
793774b 
…ee-what-npm-is-installing-with-solo-and-perhaps-there-is-more-to-add-to-npmignore
@instamenta
remove ignore of the non-compiled ts code
59fe7f7 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jul 4, 2025
@instamenta instamenta marked this pull request as ready for review July 4, 2025 07:37
@instamenta instamenta requested review from a team as code owners July 4, 2025 07:37
jeromy-cannon
jeromy-cannon requested changes Jul 7, 2025
View reviewed changes
@jeromy-cannon jeromy-cannon added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. and removed PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jul 7, 2025
@instamenta
remove docs from ignored
bd79c3c 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. and removed PR: Unresolved Comments A pull request where there are comments and they need to be resolved. labels Jul 11, 2025
@instamenta
Merge remote-tracking branch 'origin/main' into 1072-go-through-and-s…
0c9330c 
…ee-what-npm-is-installing-with-solo-and-perhaps-there-is-more-to-add-to-npmignore
@jeromy-cannon jeromy-cannon removed PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Jul 11, 2025
@jeromy-cannon jeromy-cannon added the PR: Ready to Merge A pull request that is ready to merge. label Jul 11, 2025
@jeromy-cannon jeromy-cannon merged commit 158b4b5 into main Jul 14, 2025
70 of 71 checks passed
@jeromy-cannon jeromy-cannon deleted the 1072-go-through-and-see-what-npm-is-installing-with-solo-and-perhaps-there-is-more-to-add-to-npmignore branch July 14, 2025 15:40
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner automatically assigned from hiero-ledger/solo-committers

Assignees

@instamenta instamenta

Labels
PR: Ready to Merge A pull request that is ready to merge. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go through and see what NPM is installing with Solo and perhaps there is more to add to .npmignore
3 participants
@instamenta @swirlds-automation @jeromy-cannon