Skip to content

feat: Add configurable chartDirectory via separate RuntimeStates #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 91 commits into
base: main
Choose a base branch
from

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented May 27, 2025

Description

Adds initial versions of the following runtime config states:

  • ExplorerConfigRuntimeState
  • MirrorNodeConfigRuntimeState
  • BlockNodeConfigRuntimeState
  • JsonRpcRelayConfigRuntimeState

All of those states have their Schema, which for now only contains a helmChart configuration.
The runtime states are implemented into the respective Command classes, and the chartDirectory is read from them.

Removes the chartDirectory flag. The user can now set the chart directory via the following env variables:

SOLO_HELM-CHART_DIRECTORY=path/to/chart
SOLO_MIRROR_NODE_HELM-CHART_DIRECTORY=path/to/chart
SOLO_BLOCK_NODE_HELM-CHART_DIRECTORY=path/to/chart
SOLO_EXPLORER_HELM-CHART_DIRECTORY=path/to/chart
SOLO_JSON_RPC_RELAY_HELM-CHART_DIRECTORY=path/to/chart

Related Issues

  • Closes #
  • Related to #

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

The following manual testing was done:

  • TBD

The following was not tested:

  • TBD
Commit message guidelines We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:
  1. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
  2. The title is prefixed with one of the following:
Prefix Description Semantic Version Update Captured in Release Notes
feat: a new feature MINOR Yes
fix: a bug fix PATCH Yes
perf: performance PATCH Yes
refactor: code change that isn't feature or fix none No
test: adding missing tests none No
docs: changes to documentation none Yes
build: changes to build process none No
ci: changes to CI configuration none No
style: formatting, missing semi-colons, etc none No
chore: updating grunt tasks etc; no production code change none No

Ivo-Yankov and others added 27 commits May 16, 2025 10:56
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
… test cases (#1993)

Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Co-authored-by: Nathan Klick <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
… into 01973-create-solo-runtime-state

# Conflicts:
#	src/business/runtime-state/config/solo/solo-config-runtime-state.ts
@Ivo-Yankov Ivo-Yankov self-assigned this May 27, 2025
Copy link
Contributor

github-actions bot commented May 27, 2025

Unit Test Results - Linux

32 tests  ±0   32 ✅ ±0   0s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e2c767f. ± Comparison against base commit aae5e1b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 27, 2025

Unit Test Results - Windows

  1 files  ± 0  142 suites  +20   3s ⏱️ -1s
403 tests +30  403 ✅ +30  0 💤 ±0  0 ❌ ±0 
415 runs  +38  415 ✅ +38  0 💤 ±0  0 ❌ ±0 

Results for commit e2c767f. ± Comparison against base commit aae5e1b.

♻️ This comment has been updated with latest results.

Ivo-Yankov and others added 16 commits June 2, 2025 10:35
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
… test cases (#1993)

Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Co-authored-by: Nathan Klick <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
…a-helm-chart-directory-for-other-helm-charts-like-we-do-for-solo-charts-directory' into 1873-add-the-ability-to-provide-a-helm-chart-directory-for-other-helm-charts-like-we-do-for-solo-charts-directory

# Conflicts:
#	src/business/utils/reflect-assist.ts
#	src/commands/block-node.ts
#	src/commands/mirror-node.ts
#	src/commands/relay.ts
#	src/core/dependency-injection/inject-tokens.ts
#	test/unit/business/runtime-state/solo-config-runtime-state.test.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review June 2, 2025 12:35
@Ivo-Yankov Ivo-Yankov requested review from a team as code owners June 2, 2025 12:35
@Ivo-Yankov Ivo-Yankov added the PR: Needs Team Approval A pull request that needs review from a team member. label Jun 2, 2025
@Ivo-Yankov Ivo-Yankov changed the title feat: Add configurable chartDirectory feat: Add configurable chartDirectory via separate RuntimeStates Jun 2, 2025
Copy link
Contributor

@nathanklick nathanklick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Hold

@jeromy-cannon jeromy-cannon added Blocked Further development work is blocked by other item and removed PR: Needs Team Approval A pull request that needs review from a team member. labels Jun 3, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve scripts folder changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Further development work is blocked by other item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants