-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Add configurable chartDirectory via separate RuntimeStates #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ivo-Yankov
wants to merge
91
commits into
main
Choose a base branch
from
1873-add-the-ability-to-provide-a-helm-chart-directory-for-other-helm-charts-like-we-do-for-solo-charts-directory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Ivo Yankov <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
… test cases (#1993) Signed-off-by: Nathan Klick <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Nathan Klick <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
… into 01973-create-solo-runtime-state # Conflicts: # src/business/runtime-state/config/solo/solo-config-runtime-state.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Ivo Yankov <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
… test cases (#1993) Signed-off-by: Nathan Klick <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Nathan Klick <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
…a-helm-chart-directory-for-other-helm-charts-like-we-do-for-solo-charts-directory' into 1873-add-the-ability-to-provide-a-helm-chart-directory-for-other-helm-charts-like-we-do-for-solo-charts-directory # Conflicts: # src/business/utils/reflect-assist.ts # src/commands/block-node.ts # src/commands/mirror-node.ts # src/commands/relay.ts # src/core/dependency-injection/inject-tokens.ts # test/unit/business/runtime-state/solo-config-runtime-state.test.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
nathanklick
requested changes
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Hold
andrewb1269hg
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and approve scripts
folder changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds initial versions of the following runtime config states:
ExplorerConfigRuntimeState
MirrorNodeConfigRuntimeState
BlockNodeConfigRuntimeState
JsonRpcRelayConfigRuntimeState
All of those states have their Schema, which for now only contains a
helmChart
configuration.The runtime states are implemented into the respective Command classes, and the
chartDirectory
is read from them.Removes the
chartDirectory
flag. The user can now set the chart directory via the following env variables:Related Issues
Pull request (PR) checklist
package.json
changes have been explained to and approved by a repository managerTesting
The following manual testing was done:
The following was not tested:
Commit message guidelines
We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages: