Skip to content

chore(block-node): validate version v0.62.0 works with block node #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

instamenta
Copy link
Contributor

Description

Validates that block node is working correctly with version v0.62.0

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta self-assigned this May 7, 2025
@instamenta instamenta requested review from a team as code owners May 7, 2025 11:31
Copy link
Contributor

github-actions bot commented May 7, 2025

Unit Test Results - Linux

32 tests  ±0   32 ✅ ±0   0s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e66cd42. ± Comparison against base commit 98bae09.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 7, 2025

Unit Test Results - Windows

  1 files  ± 0   85 suites  +3   2s ⏱️ -2s
360 tests +22  360 ✅ +22  0 💤 ±0  0 ❌ ±0 
365 runs  +22  365 ✅ +22  0 💤 ±0  0 ❌ ±0 

Results for commit e66cd42. ± Comparison against base commit 98bae09.

♻️ This comment has been updated with latest results.

instamenta and others added 24 commits May 8, 2025 09:10
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…-destroy' into test-block-node-version

# Conflicts:
#	src/commands/block-node.ts
#	version.ts
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
…1967)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…d implementations (#1965)

Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <[email protected]>
Signed-off-by: Jessica G <[email protected]>
Co-authored-by: Jessica G <[email protected]>
# Conflicts:
#	src/commands/network.ts
#	src/core/config/remote/remote-config-validator.ts
#	test/unit/commands/network.test.ts
#	test/unit/data/schema/migration/impl/remote/remote-config-v1-migration.test.ts
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta requested a review from a team as a code owner May 16, 2025 11:14
@instamenta instamenta requested a review from jeromy-cannon May 16, 2025 11:14
Copy link
Contributor

E2E Test Report

 18 files  124 suites   2h 4m 7s ⏱️
327 tests 327 ✅ 0 💤 0 ❌
342 runs  342 ✅ 0 💤 0 ❌

Results for commit e66cd42.

Copy link
Contributor

E2E Test Report

 18 files  124 suites   2h 4m 7s ⏱️
327 tests 327 ✅ 0 💤 0 ❌
342 runs  342 ✅ 0 💤 0 ❌

Results for commit e66cd42.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 98bae091 90.35%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (98bae09) Report Missing Report Missing Report Missing
Head commit (e66cd42) 36954 31090 84.13%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1941) 1026 927 90.35%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@instamenta instamenta added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels May 19, 2025
@instamenta instamenta merged commit 162d70d into 01756-implement-solo-block-nodes-destroy May 19, 2025
38 of 41 checks passed
@instamenta instamenta deleted the test-block-node-version branch May 19, 2025 14:09
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Manager Approval A pull request that needs review from a manager. PR: Needs Team Approval A pull request that needs review from a team member. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants