-
Notifications
You must be signed in to change notification settings - Fork 14
feat(remote-config): add support for multiple components of the same type, and change from hard to soft delete #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(remote-config): add support for multiple components of the same type, and change from hard to soft delete #1846
Conversation
Signed-off-by: Zhan Milenkov <[email protected]>
…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components # Conflicts: # src/core/config/remote/components/consensus-node-component.ts # src/core/config/remote/components/relay-component.ts # src/core/config/remote/remote-config-manager.ts
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Unit Test Results - Windows 1 files ± 0 73 suites - 12 4s ⏱️ ±0s Results for commit 05ffff4. ± Comparison against base commit 1a51877. This pull request removes 89 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
E2E Test Report 17 files ±0 120 suites +1 1h 30m 29s ⏱️ + 2m 34s Results for commit 3292683. ± Comparison against base commit 0088b76. This pull request removes 12 and adds 16 tests. Note that renamed tests count towards both.
|
E2E Test Report 17 files ±0 120 suites +1 1h 25m 17s ⏱️ - 1m 52s Results for commit 3788778. ± Comparison against base commit 484f219. This pull request removes 12 and adds 15 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
- Coverage 82.18% 81.97% -0.21%
==========================================
Files 243 245 +2
Lines 34816 34818 +2
Branches 2956 2303 -653
==========================================
- Hits 28612 28543 -69
- Misses 6051 6165 +114
+ Partials 153 110 -43
🚀 New features to boost your workflow:
|
…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…ross commands' Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
… on RelayComponent to consensusNodeIds, removed nodeStates on ConsensusNodeComponent Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components # Conflicts: # src/business/runtime-state/local-config-runtime-state.ts # src/core/dependency-injection/container-init.ts # src/data/backend/impl/yaml-config-map-storage-backend.ts # test/unit/data/configuration/impl/local-config-source.test.ts # test/unit/data/schema/migration/impl/remote/remote-config-v1-migration.test.ts # test/unit/data/schema/model/local/local-config.test.ts # test/unit/data/schema/model/remote/remote-config.test.ts
Signed-off-by: Zhan Milenkov <[email protected]>
…oad() the source Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…d implementations Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Nathan Klick <[email protected]>
Signed-off-by: Nathan Klick <[email protected]>
…l config Signed-off-by: Jeromy Cannon <[email protected]>
…-map Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
…ss facade implementations Signed-off-by: Jeromy Cannon <[email protected]>
…adeMap for consistency Signed-off-by: Jeromy Cannon <[email protected]>
… and encapsulatedArray for clarity in mutable facade implementations Signed-off-by: Jeromy Cannon <[email protected]>
…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components # Conflicts: # src/core/config/remote/common-flags-data-wrapper.ts # src/core/config/remote/interfaces/remote-config-common-flags-struct.ts # src/core/config/remote/interfaces/remote-config-metadata-struct.ts # src/core/config/remote/metadata.ts # src/core/config/remote/remote-config-manager.ts # src/core/config/remote/remote-config-validator.ts # test/e2e/integration/core/remote-config-validator.test.ts # test/unit/core/config/remote/metadata.test.ts # test/unit/data/schema/migration/impl/remote/remote-config-v1-migration.test.ts
Signed-off-by: Zhan Milenkov <[email protected]>
…-refactor-remote-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components # Conflicts: # src/commands/deployment.ts # src/commands/explorer.ts # src/commands/network.ts # src/commands/node/configs.ts # src/commands/node/tasks.ts # src/commands/relay.ts # src/core/account-manager.ts # src/core/config/remote/interfaces/migration-struct.ts # src/core/config/remote/interfaces/remote-config-metadata-struct.ts # src/core/config/remote/metadata.ts # src/core/config/remote/migration.ts # src/core/config/remote/remote-config-manager.ts # src/core/config/remote/remote-config-validator.ts # src/core/middlewares.ts # src/core/profile-manager.ts # src/data/configuration/impl/remote-config-source.ts # src/data/schema/model/local/deployment-schema.ts # src/data/schema/model/remote/remote-config-metadata.ts # src/data/schema/model/remote/remote-config.ts # src/data/schema/model/remote/state/block-node-state-schema.ts # src/data/schema/model/remote/state/consensus-node-state-schema.ts # src/data/schema/model/remote/state/envoy-proxy-state-schema.ts # src/data/schema/model/remote/state/explorer-state-schema.ts # src/data/schema/model/remote/state/haproxy-state-schema.ts # src/data/schema/model/remote/state/mirror-node-state.ts # src/data/schema/model/remote/state/relay-node-state-schema.ts # test/e2e/commands/dual-cluster-full.test.ts # test/e2e/integration/core/remote-config-validator.test.ts # test/test-utility.ts # test/unit/commands/base.test.ts # test/unit/commands/network.test.ts # test/unit/core/config/remote/metadata.test.ts # test/unit/core/config/remote/migration.test.ts # test/unit/data/schema/migration/impl/remote/remote-config-v1-migration.test.ts
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Description
Related Issues
Pull request (PR) checklist
package.json
changes have been explained to and approved by a repository managerTesting
Commit message guidelines
We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages: