Skip to content

fix: ensure network active check supports multi-cluster deployments #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: ensure network active check supports multi-cluster deployments #1431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/commands/node/tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ export class NodeCommandTasks {
? 'Please attach JVM debugger now. Sleeping for 1 hour, hit ctrl-c once debugging is complete.'
: '';
const title = `Check network pod: ${chalk.yellow(nodeAlias)} ${chalk.red(reminder)}`;
const context = helpers.extractContextFromConsensusNodes(nodeAlias, ctx.config.consensusNodes);

const subTask = async (ctx: any, task: ListrTaskWrapper<any, any, any>) => {
if (enableDebugger) {
Expand All @@ -355,6 +356,10 @@ export class NodeCommandTasks {
title,
i,
status,
undefined,
undefined,
undefined,
context,
);
};

Expand All @@ -379,6 +384,7 @@ export class NodeCommandTasks {
maxAttempts = constants.NETWORK_NODE_ACTIVE_MAX_ATTEMPTS,
delay = constants.NETWORK_NODE_ACTIVE_DELAY,
timeout = constants.NETWORK_NODE_ACTIVE_TIMEOUT,
context?: string,
): Promise<PodRef> {
nodeAlias = nodeAlias.trim() as NodeAlias;
const podName = Templates.renderNetworkPodName(nodeAlias);
Expand All @@ -397,7 +403,7 @@ export class NodeCommandTasks {

try {
const response = await this.k8Factory
.default()
.getK8(context)
.containers()
.readByRef(ContainerRef.of(podRef, constants.ROOT_CONTAINER))
.execContainer([
Expand Down
Loading