Skip to content

fix: Resolve cannot read properties of undefined error thrown during solo network deploy #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/commands/network.ts
Original file line number Diff line number Diff line change
Expand Up @@ -850,13 +850,14 @@
`solo.hedera.com/node-id=${consensusNode.nodeId},solo.hedera.com/type=network-node-svc`,
]);

if (svc && svc.length > 0 && svc[0].status.loadBalancer.ingress.length > 0) {
if (svc && svc.length > 0 && svc[0].status?.loadBalancer?.ingress?.length > 0) {
return;
}

attempts++;
await helpers.sleep(Duration.ofSeconds(2));
}
throw new SoloError('Load balancer not found');

Check warning on line 860 in src/commands/network.ts

View check run for this annotation

Codecov / codecov/patch

src/commands/network.ts#L860

Added line #L860 was not covered by tests
},
});
}
Expand Down
Loading