chore: account init to update node admin key #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
+ Coverage 83.62% 83.65% +0.03%
==========================================
Files 132 132
Lines 25209 25284 +75
Branches 1663 1753 +90
==========================================
+ Hits 21081 21152 +71
+ Misses 4099 4000 -99
- Partials 29 132 +103
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
jeromy-cannon
requested changes
Feb 12, 2025
jeromy-cannon
added
the
PR: Unresolved Comments
Signed-off-by: Jeffrey Tang <[email protected]>
jeromy-cannon
added
the
PR: Merge Conflicts
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
…node-adminkey Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts # src/commands/node/tasks.ts
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
JeffreyDallas
added
PR: Needs Team Approval
Signed-off-by: Jeffrey Tang <[email protected]>
jeromy-cannon
approved these changes
Feb 15, 2025
jeromy-cannon
removed
PR: Needs Team Approval
jeromy-cannon
added
the
PR: Ready to Merge
|
🎉 This PR is included in version 0.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues
solo account initto generate non genesis keys for node admin keys, due to Dynamic Address Book updates #525