Skip to content

Ensure that when the Update README.md job runs during Deploy Release Artifact it uses the new version tag #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeromy-cannon opened this issue Sep 17, 2024 · 1 comment · Fixed by #594 or #598
Assignees
Labels
P3 Low priority issue. Will not impact the release schedule if not complete. released

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Sep 17, 2024

When the job currently runs it does a check out of the ref used to kick off the workflow, but we need it to use the ref created when version was bumped and committed in the job prior.

Also, it looks like the tag was created against the commit that happened prior to the update readme commit.

see: https://github.com/hashgraph/solo/actions/runs/10909637150/job/30278329434

@jeromy-cannon jeromy-cannon added the P3 Low priority issue. Will not impact the release schedule if not complete. label Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Sep 17, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Sep 17, 2024
@jeromy-cannon jeromy-cannon self-assigned this Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Sep 17, 2024
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority issue. Will not impact the release schedule if not complete. released
Projects
None yet
2 participants