Skip to content

refactor remote config logic so the components name's are always unique, change logic from hard delete to soft delete for components #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
instamenta opened this issue Apr 8, 2025 · 0 comments · May be fixed by #1846
Open

refactor remote config logic so the components name's are always unique, change logic from hard delete to soft delete for components #1822

instamenta opened this issue Apr 8, 2025 · 0 comments · May be fixed by #1846
Assignees
@instamenta
Labels
P1 High priority issue. Required to be completed in the assigned milestone. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.

Comments

@instamenta
Copy link
Contributor

instamenta commented Apr 8, 2025 •
edited
Loading

Description

  • Refactor the logic used to generate component names in remote config to ensure uniqueness across all components, and allow to have multiple instances of relay, mirror nodes, explorers, and block nodes.

  • Switch from hard delete to soft delete for remote config components, preserving data for deleted components.

  • Introduce a mechanism to track and retrieve the next available index when generating unique component names.

  • Even if deleted the component's name shouldn't be reused.

  • Make sure that the indexed value starts from 0 and increments with each component.

Example:

  • Current: mirror-node becomes mirror-node-1 and then increments with each one deployed
@instamenta instamenta self-assigned this Apr 8, 2025
@instamenta instamenta changed the title asdasd refactor remote config components title so they are unique, remove logic for deleting components and instead flag them as deleted Apr 8, 2025
@instamenta instamenta added this to Solo Apr 8, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Apr 8, 2025
@instamenta instamenta added the P0 An issue impacting production environments or impacting multiple releases or multiple individuals. label Apr 8, 2025
@instamenta instamenta changed the title refactor remote config components title so they are unique, remove logic for deleting components and instead flag them as deleted refactor remote config logic so the components name's are always unique, change logic from hard delete to soft delete for components Apr 8, 2025
@instamenta instamenta mentioned this issue Apr 8, 2025
Merged
@instamenta instamenta moved this from 🆕 New to 🔖 Ready in Solo Apr 8, 2025
@instamenta instamenta moved this from 🔖 Ready to 🏗 In progress in Solo Apr 8, 2025
@instamenta instamenta moved this from 🏗 In progress to 👀 In review in Solo Apr 14, 2025
@instamenta instamenta moved this from 👀 In review to 🏗 In progress in Solo Apr 14, 2025
@instamenta instamenta linked a pull request Apr 15, 2025 that will close this issue
Draft
@instamenta instamenta linked a pull request Apr 15, 2025 that will close this issue
feat(remote-config): add support for multiple components of the same type, and change from hard to soft delete #1846
Draft
@jeromy-cannon jeromy-cannon added P1 High priority issue. Required to be completed in the assigned milestone. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. and removed P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@instamenta instamenta

Labels
P1 High priority issue. Required to be completed in the assigned milestone. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
Milestone
No milestone
2 participants
@jeromy-cannon @instamenta